add BashWithOpts command for strict bash exec #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmudar
commented
Oct 31, 2022
burmudar
commented
Oct 31, 2022
sanderginn
approved these changes
Oct 31, 2022
Contributor
There was a problem hiding this comment.
Instinctively I would want pipe failures to exit with error codes by default. What's the motivation to implement it as a standalone option?
Contributor
|
Also thank you for picking this up 🚀 |
Co-authored-by: Sander Ginn <sanderginn@users.noreply.github.com>
bobheadxi
requested changes
Oct 31, 2022
bobheadxi
reviewed
Oct 31, 2022
Co-authored-by: Robert Lin <robert@bobheadxi.dev>
bobheadxi
approved these changes
Oct 31, 2022
Contributor
Author
Sorry @sanderginn missed your comment and only saw it now. Forcing it now to run with bash strictness might break other scripts so I opted to add it as a separate call. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #44 a command seems to not return an error from a command that is executed. Upon further investigation it is because the command is executed with
bash -c, which means bash default options which means that if the last command of a pipe succeeds, the entire pipe statement is considered to have succeeded regardless if earlier statements have failed. A common "fix" for this is to enablepipefailanderrexitoptions in bash.This PR adds easier way for users to execute some bash scripts with "strict" bash and possibly avoid unexpected errors.
Closes #44