instrumentation: add run.LogCommands, run.TraceCommands #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 73.95% 77.77% +3.82%
==========================================
Files 10 11 +1
Lines 311 378 +67
==========================================
+ Hits 230 294 +64
- Misses 64 68 +4
+ Partials 17 16 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
70e7b4e to
4707e24
Compare
4707e24 to
36eea20
Compare
6323ac8 to
6fc7be6
Compare
4cb2083 to
9faf79c
Compare
9faf79c to
4355724
Compare
daxmc99
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
We are going to use this shortly in our internal CLI!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes two ways to instrument an application that executes a lot of commands you might want to debug:
run.TraceCommandstoggles OpenTelemetry tracing of commands executed within a contextrun.LogCommandstoggles logging of executed commands within a contextSee
instrumentation_test.gofor sample usages.In https://github.com/sourcegraph/controller, tracing could become used as audit log type things, while logging could be useful for debugging in general.
Open to ideas here :)