8000 Reflect func/method name in godoc by jhchabran · Pull Request #40 · sourcegraph/run · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@jhchabran
Copy link
Contributor

Was reading some code and stumbled on these :)

@jhchabran jhchabran requested a review from michaellzc as a code owner June 6, 2022 19:28
@jhchabran jhchabran requested a review from bobheadxi June 6, 2022 19:28
@codecov-commenter
Copy link

Codecov Report

Merging #40 (e6c9efe) into main (5af4f30) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   73.78%   73.78%           
=======================================
  Files          10       10           
  Lines         309      309           
=======================================
  Hits          228      228           
  Misses         64       64           
  Partials       17       17           
Impacted Files Coverage Δ
command.go 60.00% <ø> (ø)
output.go 90.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af4f30...e6c9efe. Read the comment docs.

Copy link
Member
@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Evidently was quite torn on naming here 😆

@bobheadxi bobheadxi merged commit 5d085c1 into main Jun 6, 2022
@bobheadxi bobheadxi deleted the fix-godoc branch June 6, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0