output: fix io.Reader when used with LineMap #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
bobheadxi
changed the title
output: fix io.Reader again
output: fix io.Reader when used with LineMap
May 31, 2022
jhchabran
left a comment
bobheadxi
force-pushed
the
io-read-is-wrong-again
branch
from
May 31, 2022 18:17
jhchabran
approved these changes
May 31, 2022
Contributor
There was a problem hiding this comment.
Indeed this is getting complicated. But that's fine as we're learning as we go through. Trying to see how we can refactor all of it during the offsite would be a cool activity 😊
| return dst.Write(bytes.ReplaceAll(line, []byte("world"), []byte("jh"))) | ||
| }) | ||
| }, | ||
| expect: "goodbye jh", |
Contributor
There was a problem hiding this comment.
Technically, it's good morning here 😆 🤗
Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr>
6f038bd to
dbbf2bd
Compare
Member
Author
Sounds like a great exercise! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed LineMaps are not applied in my "fix" for io.Reader in which I kind of completely forgot about LineMaps.
The implementation is not ideal, there are quite a few layers of buffering. I explored incremental reading of the command output, but it's super hard (impossible?) without lookahead, since we never know when the line has really ended, and LineMap depends on full lines
I wonder if we can lift line map assignment out of output, and into command. Then we can perhaps deal purely with mapped output
tldr I might have overcomplicated things 😂😂😂