8000 arg: introduce Arg alias, add note about quoting by bobheadxi · Pull Request #36 · sourcegraph/run · GitHub 8000
[go: up one dir, main page]
Skip to content

arg: introduce Arg alias, add note about quoting #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bobheadxi merged 1 commit into from
May 27, 2022
Merged

arg: introduce Arg alias, add note about quoting #36

bobheadxi merged 1 commit into from
May 27, 2022

Conversation

@bobheadxi
Copy link
Member
@bobheadxi bobheadxi commented May 27, 2022

Example:

run.Cmd(ctx, "echo", run.Arg("hello world!")).Run().Wait()

This was a source of confusion recently: #34 , so we introduce an "official" way to quote things.

@bobheadxi bobheadxi requested review from a team and daxmc99 May 27, 2022 17:30
@bobheadxi bobheadxi requested a review from michaellzc as a code owner May 27, 2022 17:30
@bobheadxi bobheadxi mentioned this pull request May 27, 2022
Closed
daxmc99
daxmc99 approved these changes May 27, 2022
View reviewed changes
Copy link
@daxmc99 daxmc99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Nice!
Thanks for adding this

@bobheadxi bobheadxi merged commit c1bec3b into main May 27, 2022
@bobheadxi bobheadxi deleted the cmd-arg branch May 27, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaellzc michaellzc Awaiting requested review from michaellzc michaellzc is a code owner

1 more reviewer

@daxmc99 daxmc99 daxmc99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobheadxi @daxmc99
0