output: refactor error handling and fix io.Reader implementation #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 69.68% 73.06% +3.37%
==========================================
Files 8 8
Lines 353 297 -56
==========================================
- Hits 246 217 -29
+ Misses 86 63 -23
+ Partials 21 17 -4
Continue to review full report at Codecov.
|
0b5e3a0 to
3e6dfce
Compare
9e59e92 to
20716a9
Compare
michaellzc
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all the command-error-waiting stuff with a simple
writer.CloseWithError- this means that read operations now return our command error after the buffer is cleared from reads. This greatly simplifies most of the output code - now, we can simply bubble up errors from read operations. It also means the io.Reader implementation is now correct (closes #23)!Real-life example that now works thanks to the updated io.Reader implementation: https://github.com/sourcegraph/sourcegraph/pull/35836