Upgrade to typescript 2.4.2 #356
Conversation
I don't know tbh why ast.ts doesn't simply use |
This fixes imports (tests and at runtime)
|
@felixfbecker: Only the typing issue with Observables remains, might be an easy fix for you? I got lost in RxJS operators last night, perhaps replacing Some notes for future review:
|
These files were not pre-loaded by ensure, so addSourceFile only added empty content. They were present in TS, but had no symbols.
|
An update on the imports issue: I added I have two ideas left to pursue:
The importing logic in |
compilerHost now assumes fileExists and readFile are implemented on LanguageServiceHost.
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
===========================================
+ Coverage 60.2% 74.56% +14.36%
===========================================
Files 14 14
Lines 2151 1671 -480
Branches 351 313 -38
===========================================
- Hits 1295 1246 -49
+ Misses 706 279 -427
+ Partials 150 146 -4
Continue to review full report at Codecov.
|
|
ping @felixfbecker: I think we are ready for a review on this. Today's update:
|
|
Upgrading to TS 2.5.2 showed new compile errors (packages.ts also needs the |
|
Awesome, I'll take a look when I find time |
Upgrading directly to 2.5 yielded even more issues, this smaller bump should be more manageable.
Compile errors remaining:
Observable<never>s to which we concatObservable<DesiredResultType>Test issues remaining: