8000 Add more FileSystemWatcher patterns, to improve refresh of submodules by goran-w · Pull Request #1345 · sourcegit-scm/sourcegit · GitHub
[go: up one dir, main page]

Skip to content

Add more FileSystemWatcher patterns, to improve refresh of submodules #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

goran-w
Copy link
Contributor
@goran-w goran-w commented May 21, 2025

Fixes #1344.

Added a few more patterns in Watcher.OnRepositoryChanged() and Watcher.OnWorkingCopyChanged() :

  • Skip files frequently updated by Git fsmonitor--daemon and Visual Studio, to ease debugging and for early exit.
  • Skip .git file under submodule directories, for consistency.
  • Check also for ORIG_HEAD under .git/modules/<submodule>/, to improve handling of submodules.
  • Check for MERGE_HEAD and AUTO_MERGE under .git/, to improve handling of submodules (etc) during merging.

NOTE: Maybe the MERGE_HEAD and/or AUTO_MERGE files should affect some other update-timers as well, if needed to improve refresh during Merging? (Currently only affecting _updateSubmodules and _updateWC.)

Skip files frequently updated by Git fsmonitor--daemon and Visual Studio, to ease debugging and for early exit.
Check for HEAD and ORIG_HEAD under .git/modules/<submodule>/, to improve handling of submodules.
Check for MERGE_HEAD and AUTO_MERGE under .git/, to improve handling of submodules.
@goran-w goran-w changed the title Added more FileSystemWatcher patterns, to improve handling Add more FileSystemWatcher patterns, to improve refresh of submodules May 21, 2025
@love-linger love-linger self-assigned this May 22, 2025
@love-linger love-linger added the bug Something isn't working label May 22, 2025
@love-linger love-linger merged commit 44c83ef into sourcegit-scm:develop May 22, 2025
13 checks passed
@goran-w goran-w deleted the refresh_submodules_on_merge branch May 22, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0