8000 Extra caption button displayed on macOS due to missing platform check · Issue #1311 · sourcegit-scm/sourcegit · GitHub
[go: up one dir, main page]
Skip to content

Extra caption button displayed on macOS due to missing platform check #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ChiahongHong opened this issue May 13, 2025 · 1 comment
Closed

Extra caption button displayed on macOS due to missing platform check #1311

ChiahongHong opened this issue May 13, 2025 · 1 comment
Assignees
@love-linger
Labels
bug Something isn't working

Comments

@ChiahongHong
Copy link
Contributor

In the refactoring made in ef4b639, the condition for HasRightCaptionButton doesn't check properly. As a result, an extra caption button is displayed on macOS.

sourcegit/src/Views/Launcher.axaml.cs

Lines 32 to 35 in ef4b639

public bool HasRightCaptionButton
{
get => OperatingSystem.IsWindows() || !Native.OS.UseSystemWindowFrame;
}

love-linger added a commit that referenced this issue May 13, 2025
@love-linger
fix: right caption buttons should not visible on macOS (#1311)
0e61a01 
Signed-off-by: leo <longshuang@msn.cn>
@love-linger love-linger self-assigned this May 13, 2025
@love-linger love-linger added the bug Something isn't working label May 13, 2025
@love-linger
Copy link
Collaborator

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@love-linger love-linger

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@love-linger @ChiahongHong
0