Cleaned up Recursive Knapsack#440
Open
MarshedToMallow wants to merge 2 commits intosouravjain540:mainfrom
Open
Cleaned up Recursive Knapsack#440MarshedToMallow wants to merge 2 commits intosouravjain540:mainfrom
MarshedToMallow wants to merge 2 commits intosouravjain540:mainfrom
Conversation
Author
|
Any review on this would be much appreciated. Been in limbo for nearly 2 years now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The program was somewhat messy and unclear so I went ahead and tried to make it more readable. I changed the 1-3 letter variables to proper names, added comments and a docstring, and broke up the function to make each individual step more clear.