8000 [WIP] Add symfony 3.0 support by rande · Pull Request #212 · sonata-project/SonataCoreBundle · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Sep 30, 2021. It is now read-only.

[WIP] Add symfony 3.0 support #212

Merged
merged 8 commits into from
Nov 26, 2015
Merged

[WIP] Add symfony 3.0 support #212

merged 8 commits into from
Nov 26, 2015

Conversation

rande
Copy link
Member
@rande rande commented Nov 23, 2015

No description provided.

soullivaneuh
soullivaneuh reviewed Nov 23, 2015
View reviewed changes
Form/Type/BooleanType.php
return 'sonata_type_boolean';
}
}
}
Copy link
Member
< 8000 /div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

@rande rande force-pushed the fix_deprecation_notices branch from 00a3ed3 to 38f32cb Compare November 23, 2015 17:46
@rande rande mentioned this pull request Nov 23, 2015
Closed
@rande
Copy link
Member Author
rande commented Nov 23, 2015

Waiting for symfony/symfony#16615 to be merged

@rande rande changed the title fix deprecated notices [WIP] fix deprecated notices Nov 23, 2015
@rande rande force-pushed the fix_deprecation_notices branch from 38f32cb to 0bd414f Compare November 23, 2015 18:22
@rande
Copy link
Member Author
rande commented Nov 23, 2015

@Ener-Getick I just integrate some of your changes.

@GuilhemN
Copy link

👍

@rande rande force-pushed the fix_deprecation_notices branch from ca98219 to cf448ba Compare November 25, 2015 13:40
@rande rande force-pushed the fix_deprecation_notices branch from cf448ba to 98ec031 Compare November 25, 2015 13:49
GuilhemN
GuilhemN reviewed Nov 25, 2015
View reviewed changes
Tests/Form/Type/DoctrineORMSerializationTypeTest.php
@@ -63,7 +65,12 @@ public function testBuildForm()
$metadataFactory = $this->getMetadataFactoryMock();
$registry = $this->getRegistryMock();

$type = new DoctrineORMSerializationType($metadataFactory, $registry, 'form_type_test', $this->class, 'serialization_api_write');
if (Kernel::MAJOR_VERSION < 3) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with this check is that the deprecations are not removed for sf 2.8 so the Travis build will fail... :-/

@rande rande changed the title [WIP] fix deprecated notices [WIP] Add symfony 3.0 support Nov 26, 2015
@rande rande force-pushed the fix_deprecation_notices branch from 5b20405 to 4733415 Compare November 26, 2015 09:40
@rande rande force-pushed the fix_deprecation_notices branch from 4733415 to e72af31 Compare November 26, 2015 10:29
rande added a commit that referenced this pull request Nov 26, 2015
@rande
Merge pull request #212 from sonata-project/fix_deprecation_notices
b0663c5 
[WIP] Add symfony 3.0 support
@rande rande merged commit b0663c5 into master Nov 26, 2015
@rande rande deleted the fix_deprecation_notices branch November 26, 2015 11:24
@OskarStark
Copy link
Member

👍

@deguif deguif mentioned this pull request Jul 18, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rande @GuilhemN @OskarStark @soullivaneuh
0