Move Security ACL dependency to required again #3487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 it looks like the sonata 2.3 branch is missing something needed for symfony 2.8. lots of failures about TwigBundle not being active. this is the same on the 2.3 branch builds: https://travis-ci.org/sonata-project/SonataAdminBundle/builds/95146566 - looks like something in the setup of symfony changed. i propose we merge this PR as is, it does fix a problem. the test setup for 2.8 should be checked to get rid of the errors, but the two things have nothing to do with each other. |
rande
added a commit
that referenced
this pull request
Dec 14, 2015
Move Security ACL dependency to required again
greg0ire
pushed a commit
to greg0ire/SonataAdminBundle
that referenced
this pull request
Dec 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's strange to say "you have to require
symfony/security-aclin order to use this bundle in Symfony >2.8", as making sure packages are usuable is exactly the task of Composer.The bug (ref #3152) that was causing problems when this was added as a requirement a half year ago has been fixed on Symfony's side (ref symfony/symfony#16144) and is included in all latest releases of the maintained versions (2.3.25, 2.7.7, 2.8.0 and 3.0.0). So it should not cause any troubles again.