10000 Add docker volume to db container by ApertureDevelopment · Pull Request #361 · solidnerd/docker-bookstack · GitHub
[go: up one dir, main page]
Skip to content

Add docker volume to db container #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add docker volume to db container #361

wants to merge 1 commit into from

Conversation

ApertureDevelopment
Copy link

In the manual instructions we are not creating a docker volume or mount path to have the database in a secure location. This is an issue when updating the container or when the default driver changed from aufs to overlay2.
The database container created using these instructions cannot be destroyed or re-created without data loss.

So I propose to add a step inside the manual for the creation of docker volumes beforehand, as we do with the docker-compose file.

1.5. Create docker volumes
docker volume create bookstack_db

and change the container creation accordingly

2. Run MySQL container

docker run -d --net bookstack_nw  \
-e MYSQL_ROOT_PASSWORD=secret \
-e MYSQL_DATABASE=bookstack \
-e MYSQL_USER=bookstack \
-e MYSQL_PASSWORD=secret \
 --name="bookstack_db" \
-v bookstack_db:/var/lib/mysql \
 mysql:5.7.21

@ApertureDevelopment
Copy link
Author

I just noticed the volume option inside the dockerfile. My apologies. But I still think having a clearly named volume instead of a randomly named one would benefit the user

@rjhenry
Copy link
Collaborator
rjhenry commented Nov 16, 2022

Also, how would this interact with the volumes section of the README? I suspect that should also be updated to reflect this volume.

@stale
Copy link
stale bot commented Dec 21, 2022

This issue has been automatically marked as stale because it has not had any activity for the last 30 days. It will be closed if no further activity occurs during the next 7 days. Thank you for your contributions.

@stale stale bot added the stale label Dec 21, 2022
@stale stale bot closed this Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ApertureDevelopment @rjhenry
0