API change the shape of the incidence curves #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAINT activate doctest check with pytest by default
|
The goal is to be consistent with the conventions of scikit-learn where all |
Fix a pandas warning in load_seer
FIX do not pytest collect outside of the hazardous module folder
CI trigger build doc on all targeted branches
…ck_predict_survival_boost
ogrisel
reviewed
Jul 3, 2024
hazardous/_survival_boost.py
Outdated
| The first column holds the survival probability to any event and others the | ||
| incicence probabilities for each event. | ||
| predicted_curves : ndarray of shape (n_samples, n_events + 1, n_times) | ||
| The estimated probabilities at different time horizons. The column |
There was a problem hiding this comment.
"column" is not meaningful any more for a 3D array.
The values for event with index 0 are the estimated probabilities of staying event-free at the requested time horizons for each observation described by the matching row of X. ...
glemaitre
commented
Jul 3, 2024
ogrisel
reviewed
Jul 4, 2024
ogrisel
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change some API such that the shape of returned arrays are:
predict_probais an array of shape (n_samples, n_events)predict_cumulative_incidenceis an array of shape (n_samples, n_events, n_times)predict_survival_functionis an array of shape (n_samples, n_times)