8000 Fix possible race condition in websocket heartbeat callback by dordille · Pull Request #179 · sockjs/sockjs-node · GitHub
[go: up one dir, main page]
Skip to content

Fix possible race condition in websocket heartbeat callback #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Fix possible race condition in websocket heartbeat callback #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
< 8000 div class="mt-2 mb-2 ml-1 d-flex flex-items-center">
Diff view
3 changes: 2 additions & 1 deletion src/trans-websocket.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ class WebSocketReceiver extends transport.GenericReceiver
super

heartbeat_timeout: ->
@session.close(3000, 'No response from heartbeat')
if @session?
@session.close(3000, 'No response from heartbeat')



Expand Down
0