8000 Comparing 2.4.0...2.5.0 · socketio/socket.io · GitHub
[go: up one dir, main page]

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.4.0
Choose a base ref
...
head repository: socketio/socket.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.5.0
Choose a head ref
  • 8 commits
  • 8 files changed
  • 1 contributor

Commits on Jan 7, 2021

  1. revert: fix(security): do not allow all origins by default

    This reverts commit f78a575.
    
    This commit contains a breaking change which deviates from semver,
    which we try to follow as closely as possible. That's why this change
    is reverted and we will rather suggest users to upgrade to v3.
    
    Related: #3741
    darrachequesne committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    a169050 View commit details
    Browse the repository at this point in the history
  2. chore(release): 2.4.1

    darrachequesne committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    e6b8697 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. Configuration menu
    Copy the full SHA
    dfded53 View commit details
    Browse the repository at this point in the history
  2. fix: ignore packet received after disconnection

    Related: #3095
    
    Backported from 494c64e
    darrachequesne committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    22d4bdf View commit details
    Browse the repository at this point in the history
  3. fix: fix race condition in dynamic namespaces

    Using an async operation with `io.use()` could lead to the creation of
    several instances of a same namespace, each of them overriding the
    previous one.
    
    Example:
    
    ```js
    io.use(async (nsp, auth, next) => {
      await anOperationThatTakesSomeTime();
      next();
    });
    ```
    
    Related: #4136
    
    Backported from 9d86397
    darrachequesne committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    05e1278 View commit details
    Browse the repository at this point in the history
  4. fix: only set 'connected' to true after middleware execution

    The Socket instance is only considered connected when the "connection"
    event is emitted, and not during the middleware(s) execution.
    
    ```js
    io.use((socket, next) => {
      console.log(socket.connected); // prints "false"
      next();
    });
    
    io.on("connection", (socket) => {
      console.log(socket.connected); // prints "true"
    });
    ```
    
    Related: #4129
    
    Backported from 02b0f73
    darrachequesne committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    226cc16 View commit details
    Browse the repository at this point in the history
  5. fix: prevent the socket from joining a room after disconnection

    Calling `socket.join()` after disconnection would lead to a memory
    leak, because the room was never removed from the memory:
    
    ```js
    io.on("connection", (socket) => {
      socket.disconnect();
      socket.join("room1"); // leak
    });
    ```
    
    Related:
    
    - #4067
    - #4380
    
    Backported from 18f3fda
    darrachequesne committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    f223178 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    baa6804 View commit details
    Browse the repository at this point in the history
Loading
0