Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 6 commits
- 8 files changed
- 1 contributor
Commits on Jun 26, 2022
-
chore: update engine.io version to 3.6.0
Release notes: https://github.com/socketio/engine.io/releases/tag/3.6.0 Diff: socketio/engine.io@3.5.0...3.6.0
-
-
-
fix: only set 'connected' to true after middleware execution
The Socket instance is only considered connected when the "connection" event is emitted, and not during the middleware(s) execution. ```js io.use((socket, next) => { console.log(socket.connected); // prints "false" next(); }); io.on("connection", (socket) => { console.log(socket.connected); // prints "true" }); ``` Related: #4129 Backported from 02b0f73 -
fix: prevent the socket from joining a room after disconnection
-
Release notes: https://github.com/socketio/socket.io/releases/tag/2.5.0 Diff: 2.4.1...2.5.0
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2.4.1...2.5.0