8000 handle missing required arguments by Piefayth · Pull Request #5 · slicknode/graphql-query-complexity · GitHub
[go: up one dir, main page]
Skip to content

handle missing required arguments #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2017
Merged

handle missing required arguments #5

merged 1 commit into from
Dec 15, 2017

Conversation

Piefayth
Copy link
Contributor

Currently, if your schema has a required (non-null) argument, getArgumentValues will throw. As a result, the expected graphql response json is not created and the thrown error text is returned directly. This change handles that error as expected, and includes a test case.

@ivome ivome merged commit f5928cd into slicknode:master Dec 15, 2017
@ivome
Copy link
Collaborator
ivome commented Dec 15, 2017

Thanks for the bugfix! I only did a minor adjustment: Removing the undefined arg from the test query. 770d801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timrs2998 timrs2998 timrs2998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piefayth @ivome @timrs2998
0