8000 Add support for socks proxy by gfreezy · Pull Request #338 · slackapi/python-slack-sdk · GitHub
[go: up one dir, main page]

Skip to content

Add support for socks proxy#338

Closed
gfreezy wants to merge 2 commits intoslackapi:masterfrom
gfreezy:master
Closed

Add support for socks proxy#338
gfreezy wants to merge 2 commits intoslackapi:masterfrom
gfreezy:master

Conversation

@gfreezy
Copy link
@gfreezy gfreezy commented Jul 30, 2018

Summary

Add support for socks proxy. Have no idea why tests failed.

Requirements (place an x in each [ ])

@CLAassistant
Copy link
CLAassistant commented Jul 30, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
codecov bot commented Sep 25, 2018

Codecov Report

Merging #338 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files          10       10           
  Lines         415      415           
  Branches       74       74           
=======================================
  Hits          317      317           
  Misses         87       87           
  Partials       11       11
Impacted Files Coverage Δ
slackclient/server.py 84.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 669cb54...63c307e. Read the comment docs.

@gfreezy gfreezy closed this Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0