Separating out parsing of ims and users during RTM client login#2
Merged
rawdigits merged 6 commits intoslackapi:masterfrom Feb 13, 2015
Merged
Separating out parsing of ims and users during RTM client login#2rawdigits merged 6 commits intoslackapi:masterfrom
rawdigits merged 6 commits intoslackapi:masterfrom
Conversation
|
If call should be ? :) |
|
+1 to what @tangxingqin said. This library is busted right now because of this :( |
Contributor
Author
|
Hey guys, been away, I shall look into adding the fix to PR.
|
rawdigits
added a commit
that referenced
this pull request
Feb 13, 2015
Separating out parsing of ims and users during RTM client login
Contributor
|
Thanks for the fixes here and apologies on the delay getting this merged back into master. |
c-goosen
pushed a commit
to c-goosen/python-slackclient
that referenced
this pull request
Jun 18, 2019
Separating out parsing of ims and users during RTM client login
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps get the array of users filled so they it can be looked up later. It also separates ims from channels so that we can store realname (if present) and timezone.