-
Notifications
You must be signed in to change notification settings - Fork 226
docs: update release instructions < 10BC0 span class="f1-light color-fg-muted">#1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update release instructions #1440
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1440 +/- ##
============================================
+ Coverage 73.06% 73.09% +0.02%
- Complexity 4381 4382 +1
============================================
Files 475 475
Lines 14244 14244
Branches 1447 1447
============================================
+ Hits 10408 10412 +4
+ Misses 2977 2974 -3
+ Partials 859 858 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've added additional information about the signing process prep.
.github/maintainers_guide.md
Outdated
* Make sure there are no build failures at https://github.com/slackapi/java-slack-sdk/actions | ||
6880 * Set a new version | ||
* If you don't have `gnu-sed`, run `brew install gnu-sed` first | ||
* If you don't have `gnu-sed`, run `brew install gnu-sed` & `brew install gnupg` first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just installing GnuPG is not enough. Before making the release, there are a few steps to complete:
- Set up your key: https://central.sonatype.org/publish/requirements/gpg/
- Make sure if your account has the permission to make releases under com.slack groupId (note that this page requires login as the account)
- Update your $HOME/.m2/settings.xml
- generate user token: https://central.sonatype.org/publish/generate-token/
- set the user token id/password: https://central.sonatype.org/publish/publish-manual/#signing-components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point I moved this to prerequisites 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Everything reads well and the instructions are clear. I've left one minor suggestion on formatting, but it's a non-blocker.
Co-authored-by: Michael Brooks <michael@michaelbrooks.ca>
This PR aims to update the release instructions in the maintainers guide
Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.