Add special-case handling for multiplication by zero#3
Open
kungfooman wants to merge 1 commit intoskeate:mainfrom
Open
Add special-case handling for multiplication by zero#3kungfooman wants to merge 1 commit intoskeate:main<
8000
span class="prc-TooltipV2-Tooltip-tLeuB" data-direction="s" role="tooltip" aria-hidden="true" id="_R_1njahd_">skeate/TypeScript:mainfrom
kungfooman wants to merge 1 commit intoskeate:main<
8000
span class="prc-TooltipV2-Tooltip-tLeuB" data-direction="s" role="tooltip" aria-hidden="true" id="_R_1njahd_">skeate/TypeScript:mainfrom
Conversation
… zero to simplify types when possible)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a special-case check in
checker.tsto ensure that multiplying any numeric type by the literal 0 always results in the literal type 0. This aligns with mathematics and should speed up type resolution for e.g. unions - why do all the distribution in e.g.Multiply<1 | 2, 0>when it will be 0 anyway?TLDR: we can just short-circuit in case of zero multiplication