8000 Fix implicit `%%sql` commands when running shared and personal notebooks from `%run_shared` / `%run_personal` by kesmit13 · Pull Request #66 · singlestore-labs/singlestoredb-python · GitHub
[go: up one dir, main page]

Skip to content

Fix implicit %%sql commands when running shared and personal notebooks from %run_shared / %run_personal #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kesmit13
Copy link
Collaborator

No description provided.

Comment on lines +111 to +115
output_redirect = getattr(
cell, 'metadata', {},
).get('output_variable', '') or ''
if output_redirect:
output_redirect = f' {output_redirect} <<'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't think there is a way for output_variable to be set if language is not sql. So, you could check for this only if it's a SQL cell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0