Support allow_nan in message JSON output#183
Merged
sgandhi1311 merged 4 commits intomasterfrom Oct 22, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for controlling NaN and infinite float value serialization in JSON output by adding an allow_nan parameter to message formatting functions.
- Added
allow_nan=Falseparameter toformat_messageandwrite_messagefunctions - Enables callers to control serialization of non-finite float values (NaN, Infinity, -Infinity)
- Improves JSON compatibility with consumers that reject non-finite values
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
Can we add tests for this? |
vishalp-dev
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This change updates the format_message and write_message functions to include the allow_nan parameter in the json.dumps call.
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code