Fix incorrect ignore of temporary .d.ts files from fixtures in xo.config.js
#1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c252fa6 to
9081c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix made in #1326 didn't quite fix the issue.
I looked into the XO codebase and realised that using
ignoresinsidexo.config.jsisn't what we want over here. From what I understand, files ignored this way are still linted, they just do not have any matching rules applied. That is not sufficient in this case because these files are ephemeral, which makes the linting process flaky.This PR removes
ignoresfromxo.config.jsand moves the configuration to a CLI flag instead. This ensures the temporary files are not linted at all. Refer https://github.com/xojs/xo/blob/ceadd8d1cbbeac894ecf56936ab8e509ae5e432b/lib/xo.ts#L341.