Remove GitHub’s default styles #3
Conversation
|
ping @sindresorhus |
|
ping @D10 |
|
ping @zenorocha ;) |
| html { | ||
| font-family: sans-serif; | ||
| -ms-text-size-adjust: 100%; | ||
| -webkit-text-size-adjust: 100%; |
There was a problem hiding this comment.
these needs to be preserved
|
Thanks, but this breaks the layout. Please actually check how it looks and compare it to how it looked before (index.html) ;) |
|
Yep, will fix tomorrow ;) |
|
I've updated the PR, @sindresorhus you can review it again ;) |
| @@ -57,41 +51,39 @@ body { | |||
| } | |||
|
|
|||
| body { | |||
There was a problem hiding this comment.
this needs to be applied to .markdown-body and not body
|
Updated again, and rebased against master. |
| return false; | ||
| } | ||
|
|
||
| if (el.selectors.length === 1 && /^(?:html|body)$/.test(el.selectors[0])) { | ||
| el.declarations = el.declarations.filter(function (declaration) { | ||
| if (!/^font|^(?:line-height|color)$|text-size-adjust$/.test(declaration.property)) { |
There was a problem hiding this comment.
a why comment here would be nice
|
@D10 thanks, looking good :D There are two outstanding issues, but I would be happy to open them as separate tickets if you prefer?
Would you mind also adding yourself as a |
* Remove some `html` and `body` styles which are only applicable to GitHub * Replace `html` and `body` selectors with `.markdown-body` * Prefix all other selectors with `.markdown-body` Closes #1.
|
I won't be able to push commits for some time, you might want to fix the rest yourself :( |
Remove GitHub’s default styles
|
@D10 No worries. Thanks for this amazing PR :D |
|
I fixed both those issues and did a new release ;) |
|
thanks, d10! Works great :) |
htmlandbodystyles which are onlyapplicable to GitHub
.markdown-body