8000 Require Node.js 8, include a code snippet in the fixture, and change how we generate the HTML by pkaminski · Pull Request #5 · sindresorhus/generate-github-markdown-css · GitHub
[go: up one dir, main page]
Skip to content

Require Node.js 8, include a code snippet in the fixture, and change how we generate the HTML #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 31, 2019
Merged

Require Node.js 8, include a code snippet in the fixture, and change how we generate the HTML #5

merged 6 commits into from
Jan 31, 2019

Conversation

pkaminski
Copy link
Contributor
@pkaminski pkaminski commented Aug 24, 2018 •
edited
Loading

A normal render won't generate code snippets, so go through the API instead. This also avoids pulling in
all kinds of styles that relate only to the link anchors supplied by the GitHub site, but not part of the
markdown render proper.

This change is Reviewable

@pkaminski
Include a code snippet in the fixture, and change how we generate the…
f65fb13 
… HTML.

A normal render won't generate code snippets, so go through the API instead.  This also avoids pulling in
all kinds of styles that relate only to the link anchors supplied by the GitHub site, but not part of the
markdown render proper.
sindresorhus
sindresorhus reviewed Aug 26, 2018
View reviewed changes
sindresorhus
sindresorhus reviewed Aug 27, 2018
View reviewed changes
sindresorhus
sindresorhus reviewed Aug 27, 2018
View reviewed changes
@sindresorhus sindresorhus changed the title Include a code snippet in the fixture, and change how we generate the HTML Require Node.js 8 and include a code snippet in the fixture, and change how we generate the HTML Aug 27, 2018
@sindresorhus sindresorhus changed the title Require Node.js 8 and include a code snippet in the fixture, and change how we generate the HTML Require Node.js 8, include a code snippet in the fixture, and change how we generate the HTML Jan 31, 2019
@sindresorhus sindresorhus merged commit 8b92707 into sindresorhus:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkaminski @sindresorhus
0