use dvh units to work on mobile devices#62
Open
stepanzak wants to merge 1 commit intosimple-notify:masterfrom
Open
use dvh units to work on mobile devices#62stepanzak wants to merge 1 commit intosimple-notify:masterfrom
stepanzak wants to merge 1 commit intosimple-notify:masterfrom
Conversation
Should solve issue simple-notify#61 If the browser doesn't support dvh units, it should just ignore the line and use 100vh on the line above
Author
|
Here's where I got info about |
Author
|
I don't know whether I should do anything else when submitting a PR, like running some scripts to minify it maybe? |
Author
|
Any reason not to merge this? It's an extremely simple change and the gain from it is pretty significant, as mobile browsers are a majority of web traffic nowadays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should solve issue #61
If the browser doesn't support dvh units, it should just ignore the line and use 100vh on the line above