8000 Do not update README.md and amalgamate_demo.cpp from amalgamate.sh by pps83 · Pull Request #1070 · simdjson/simdjson · GitHub
[go: up one dir, main page]
Skip to content

Do not update README.md and amalgamate_demo.cpp from amalgamate.sh #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2020
Merged

Do not update README.md and amalgamate_demo.cpp from amalgamate.sh #1070

merged 1 commit into from
Aug 6, 2020

Conversation

pps83
Copy link
Contributor
@pps83 pps83 commented Jul 25, 2020

README.md and amalgamate_demo.cpp are always the same, there is no point to keep a copy and recreate them from amalgamate.sh

@pps83 pps83 force-pushed the bugfix/Do-not-update-README-and-amalgamate_demo branch 2 times, most recently from 2c675f7 to 5c31bce Compare July 28, 2020 15:14
jkeiser
jkeiser reviewed Jul 30, 2020
View reviewed changes
jkeiser
jkeiser reviewed Jul 30, 2020
View reviewed changes
jkeiser
jkeiser reviewed Jul 30, 2020
View reviewed changes
jkeiser
jkeiser requested changes Aug 4, 2020
View reviewed changes
Copy link
Member
@jkeiser jkeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to copy README and I think we're good. Super glad to see amalgamate_demo.cpp become static.

@pps83
Do not update README.md and amalgamate_demo.cpp from amalgamate.sh
352eb4c 
README.md and amalgamate_demo.cpp are always the same, there is no point to keep a copy and recreate them from amalgamate.sh
@pps83 pps83 force-pushed the bugfix/Do-not-update-README-and-amalgamate_demo branch from 5c31bce to 352eb4c Compare August 6, 2020 03:11
@pps83
Copy link
Contributor Author
pps83 commented Aug 6, 2020

Just need to copy README and I think we're good. Super glad to see amalgamate_demo.cpp become static.

updated

@pps83 pps83 requested a review from jkeiser August 6, 2020 18:48
jkeiser
jkeiser approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member
@jkeiser jkeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TkTech thanks for doing this, and thanks for putting up with me :)

@jkeiser jkeiser merged commit 1133c2c into simdjson:master Aug 6, 2020
@TkTech
Copy link
Member
TkTech commented Aug 6, 2020

@jkeiser wrong person :P

@jkeiser
Copy link
Member
jkeiser commented Aug 6, 2020

:embarrassed:

@pps83 thank you :)

@pps83 pps83 mentioned this pull request Aug 8, 2020
Closed
@pps83
Copy link
Contributor Author
pps83 commented Aug 8, 2020

@jkeiser Please merge follow up fix from #1103

@pps83 pps83 deleted the bugfix/Do-not-update-README-and-amalgamate_demo branch August 8, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire left review comments

@jkeiser jkeiser jkeiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pps83 @TkTech @jkeiser @lemire
0