This repository was archived by the owner on Sep 14, 2018. It is now read-only.
Added the Symfony default ide file link web view #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We only know if this works if your SF PR is merged, as the class |
|
I supposed @jeremyFreeAgent tested it manually, right? |
ed5c5dd to
2aee7b8
Compare
2aee7b8 to
d214620
Compare
|
Yes I needed to test it manually since the dependencies are not merged yet. If the |
d214620 to
485a160
Compare
02df5f4 to
49739e2
Compare
|
I've pushed the changes to reflect the ones made in the Symfony PR. |
fabpot
reviewed
Oct 25, 2016
| } | ||
| $baseDir[] = $rootDir[$i]; | ||
| } | ||
| $baseDir = implode(DIRECTORY_SEPARATOR, $baseDir); |
There was a problem hiding this comment.
Can you move this into a private method?
49739e2 to
c44ea34
Compare
c44ea34 to
7e7f062
Compare
|
Thank you @jeremyFreeAgent. |
fabpot
added a commit
that referenced
this pull request
Oct 27, 2016
…reeAgent) This PR was merged into the 2.0.x-dev branch. Discussion ---------- Added the Symfony default ide file link web view This add the feature added by symfony/symfony#19973 Commits ------- 7e7f062 Added the Symfony default ide file link web view
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the feature added by symfony/symfony#19973