8000 Fix exception hander test by chihiro-adachi · Pull Request #1528 · silexphp/Silex · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jul 4, 2018. It is now read-only.

Fix exception hander test #1528

Closed
wants to merge 2 commits into from
Closed

Fix exception hander test #1528

wants to merge 2 commits into from

Conversation

chihiro-adachi
Copy link
Contributor

In symfony 3.3.0, the markup of the error wording has been changed.

symfony/symfony#22838

3.2.x
<h1>$title</h1>

3.3.0
<h1 class="break-long-words exception-message">$title</h1>

Therefore, in the symfony 3.3.0 environment, ExceptionHandlerTest fails.

1) Silex \ Tests \ ExceptionHandlerTest :: testExceptionHandlerExceptionNoDebug
Failed asserting that '<! DOCTYPE html>

...

Contains "<h1> Whoops, looks like something went wrong. </h1>".

https://github.com/symfony/symfony/pull/22838/files#diff-5a9ac37e71d14aa261fe6f68848a6277L42

I deleted <h1> by referring to it.

@fabpot
Copy link
Member
fabpot commented Jun 2, 2017

Thank you @chihiro-adachi.

@fabpot fabpot closed this in 3435cbb Jun 2, 2017
@chihiro-adachi chihiro-adachi deleted the fix-exception-hander-test branch June 4, 2017 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chihiro-adachi @fabpot
0