This repository was archived by the owner on Jul 4, 2018. It is now read-only.
Fix AssetServiceProviderTest::testGenerateAssetUrl #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fb0423 to
ce8e41b
Compare
|
I went too fast and the "fixed" test didn't work with 3.0 and 3.1. Thus I just kept the test without the starting slash as the behavior of |
This was referenced May 2, 2017
|
Thank you @skalpa. |
fabpot
added a commit
that referenced
this pull request
May 2, 2017
This PR was merged into the 2.1.x-dev branch. Discussion ---------- Fix AssetServiceProviderTest::testGenerateAssetUrl The test broke when symfony/symfony#22528 got merged. I added one check without the starting slash (the returned path should be relative to `base_path`) and modified the expectation of the check with the starting slash (the returned path should not be relative). ``` There was 1 failure: 1) Silex\Tests\Provider\AssetServiceProviderTest::testGenerateAssetUrl Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'/whatever-makes-sense/foo.css?css2' +'/foo.css?css2' ``` Commits ------- ce8e41b Fix AssetServiceProviderTest::testGenerateAssetUrl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test broke when symfony/symfony#22528 got merged.
I added one check without the starting slash (the returned path should be relative to
base_path) and modified the expectation of the check with the starting slash (the returned path should not be relative).