This repository was archived by the owner on Jul 4, 2018. It is now read-only.
Use DebugProcessor instead of DebugHandler when available in MonologServiceProvider #1444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Nov 6, 2016
| @@ -62,8 +63,12 @@ public function register(Container $app) | |||
|
|
|||
| $log->pushHandler($handler); | |||
|
|
|||
| if ($app['debug'] && isset($app['monolog.handler.debug'])) { | |||
| $log->pushHandler($app['monolog.handler.debug']); | |||
| if ($app['debug'] && $bridge) { | |||
There was a problem hiding this comment.
Are you sure it works? $bridge is not defined in this scope.
There was a problem hiding this comment.
oups, indeed, fixed
There was a problem hiding this comment.
which means that this path is not tested at all. Could you add a test?
…erviceProvider
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 6, 2016
…le in MonologServiceProvider (nicolas-grekas) This PR was merged into the 2.0.x-dev branch. Discussion ---------- Use DebugProcessor instead of DebugHandler when available in MonologServiceProvider Related to symfony/symfony#20416 Commits ------- 213741a Use DebugProcessor instead of DebugHandler when available in MonologServiceProvider
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to symfony/symfony#20416