10000 Prepare 2.1.4 release by jku · Pull Request #961 · sigstore/sigstore-python · GitHub
[go: up one dir, main page]
Skip to content

Prepare 2.1.4 release #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2024
Merged

Prepare 2.1.4 release #961

merged 1 commit into from
Apr 5, 2024

Conversation

jku
Copy link
Member
@jku jku commented Apr 5, 2024

This is for series/2.1.x

Only change is pinning securesystemslib so future major or minor
releases will not be used (current release is 0.31.0)

We can still discuss if this makes sense or is necessary.

Fixes #960

@jku
Prepare 2.1.4 release
df798f5 
Only change is pinning securesystemslib so future major or minor
releases will not be used (current release is 0.31.0)

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku jku requested a review from woodruffw April 5, 2024 11:08
@woodruffw
Copy link
Member

No objection from me! Future-proofing makes sense.

@woodruffw woodruffw merged commit 2edc752 into sigstore:series/2.1.x Apr 5, 2024
@woodruffw
Copy link
Member

@jku feel free to cut the tag/release as well, I think we still haven't sealed that permissions hole around releases from branches 😅

@woodruffw woodruffw mentioned this pull request Apr 5, 2024
Closed
@jku
Copy link
Member Author
jku commented Apr 5, 2024

I won't 6pm on friday but I can do this on monday.

Just to make sure I've understood the process:

  • merging to the banch does not trigger anything yet
  • pushing a tag that looks like a release will trigger a GitHub release
  • GitHub release triggers the actual release workflow

@woodruffw
Copy link
Member

I won't 6pm on friday but I can do this on monday.

Just to make sure I've understood the process:

  • merging to the banch does not trigger anything yet

  • pushing a tag that looks like a release will trigger a GitHub release

  • GitHub release triggers the actual release workflow

Correct except the last part: you have to manually create the GH release from tag, and the release CI takes over from there 🙂

(I typically run gh release create locally once the tag is minted.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw Awaiting requested review from woodruffw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jku @woodruffw
0