10000 pyproject.toml: Don't check for line-length with `ruff` since we're reformatting with `black` by tetsuo-cpp · Pull Request #477 · sigstore/sigstore-python · GitHub
[go: up one dir, main page]
Skip to content

pyproject.toml: Don't check for line-length with ruff since we're reformatting with black #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2023
Merged

pyproject.toml: Don't check for line-length with ruff since we're reformatting with black #477

merged 2 commits into from
Jan 29, 2023

Conversation

tetsuo-cpp
Copy link
Contributor

@tetsuo-cpp
Makefile: Run black to break lines before linting with ruff
b27d455 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp tetsuo-cpp added refactoring Refactoring tasks. safe to test labels Jan 28, 2023
@tetsuo-cpp tetsuo-cpp changed the title Makefile: Run black to break lines before linting with ruff pyproject.toml: Don't check for line-length with ruff since we're reformatting with black Jan 29, 2023
@woodruffw woodruffw merged commit cc967a7 into main Jan 29, 2023
@woodruffw woodruffw deleted the alex/lint-ordering branch January 29, 2023 19:30
jleightcap pushed a commit that referenced this pull request Jan 31, 2023
@tetsuo-cpp @jleightcap
pyproject.toml: Don't check for line-length with ruff since we're r…
2c9bd10 
…eformatting with `black` (#477)

* Makefile: Run `black` to break lines before linting with `ruff`

Signed-off-by: Alex Cameron <asc@tetsuo.sh>

* Makefile, pyproject.toml: Stop ruff checking for line length instead

Signed-off-by: Alex Cameron <asc@tetsuo.sh>

---------

Signed-off-by: Alex Cameron <asc@tetsuo.sh>
jleightcap pushed a commit that referenced this pull request Jan 31, 2023
@tetsuo-cpp @jleightcap
pyproject.toml: Don't check for line-length with ruff since we're r…
8f84de4 
…eformatting with `black` (#477)

* Makefile: Run `black` to break lines before linting with `ruff`

Signed-off-by: Alex Cameron <asc@tetsuo.sh>

* Makefile, pyproject.toml: Stop ruff checking for line length instead

Signed-off-by: Alex Cameron <asc@tetsuo.sh>

---------

Signed-off-by: Alex Cameron <asc@tetsuo.sh>
Signed-off-by: Jack Leightcap <jack.leightcap@trailofbits.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

@di di Awaiting requested review from di

@jleightcap jleightcap Awaiting requested review from jleightcap

Assignees
No one assigned
Labels
refactoring Refactoring tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tetsuo-cpp @woodruffw
0