treewide: upgrade to cryptography 38 #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings a couple of new (and much-needed) SCT APIs, allowing us to remove a variety of nasty unpacking hacks. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
|
This should also close #142, correct? |
Yep! I'll update the top comment to auto-close that as well. |
|
Typechecks are snarled because of some obsolete dependencies in typeshed: python/typeshed#8699 |
|
I'd be OK with temporarily ignoring these typecheck failures in the interest of getting this release out. |
Sounds good. I think the |
…arily Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
This was already an implicit constraint; this change merely corrects the type hints. Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
commented
Sep 7, 2022
Signed-off-by: William Woodruff <william@trailofbits.com>
|
Should be good to go, modulo feedback on #199 (comment). |
di
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2AAA
This brings a couple of new (and much-needed) SCT APIs, allowing us to remove a variety of nasty unpacking hacks.
Signed-off-by: William Woodruff william@trailofbits.com
Closes #195.
Closes #142.