-
Notifications
You must be signed in to change notification settings - Fork 58
Verifier: Use correct Timestamp hash algorithm #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
52f38a3
to
6305fb1
Compare
Don't assume sha256. Use verify_message() from new rfc3161-client instead: it looks up the correct hash from the timestamp response. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
6305fb1
to
0da31a1
Compare
lol, I made another seemingly unrelated fix in the new rfc3161-client and now lint fails because of the combination of these two fixes... trailofbits/rfc3161-client#152 This is just a lint issue so I silenced it for now but we can also wait for next rfc3161-client release. |
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jku!
(Needs deconflict but otherwise good to go.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Don't assume sha256. Use verify_message() instead: it looks up the correct hash from the the timestamp response.