-
Notifications
You must be signed in to change notification settings - Fork 13
Cleanup workflows #148
8000 New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup workflows #148
Conversation
- remove unnecessary action argument in release workflow
- remove selftest that is now essentially a duplicate of previous test
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
release-signing-artifacts defaults to "true" so the removed test now duplicates the previous test. We could try testing the release-signing-artifacts == "false" but that's a bit trickier since it could only be done in a release event... Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
possibly for #143 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jku!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, this needs another small tweak: you need to remove selftest-release-signing-artifacts-no-op
from the all-selftests-pass
check at the bottom of the workflow to get the CI passing.
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
(sigstore#134): * schedule-selftest: reduce nagging --------- Signed-off-by: William Woodruff <william@trailofbits.com> (sigstore#140): * requirements: sigstore ~3.0 * selftest: update filenames * action: update another path * action: remove deprecated settings * README: remove old docs --------- Signed-off-by: William Woodruff <william@trailofbits.com> (sigstore#145): * action: use a venv to prevent PEP 668 errors * action: use sys.executable * fight with Windows * setup: minimum Python is 3.8 (This has been true for a while) --------- Signed-off-by: William Woodruff <william@trailofbits.com> (sigstore#142): * action: flip `release-signing-artifacts` --------- Signed-off-by: William Woodruff <william@trailofbits.com> (sigstore#146): * action: remove old output settings * selftest: remove old test ref --------- Signed-off-by: William Woodruff <william@trailofbits.com> Cleanup workflows (sigstore#148): * Workflows: remove default input arg from action call * workflows: Remove unnecessary selftest release-signing-artifacts defaults to "true" so the removed test now duplicates the previous test. We could try testing the release-signing-artifacts == "false" but that's a bit trickier since it could only be done in a release event... * workflows: Drop recently removed job from needs-list --------- Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> Prep 3.0.0 (sigstore#143): --------- Signed-off-by: William Woodruff <william@trailofbits.com> (sigstore#152): * build(deps): bump peter-evans/create-issue-from-file from 5.0.0 to 5.0.1 in the actions group --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (sigstore#154): * Fix remaining reference to 2.1.1 in README --------- Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com> (sigstore#151): * Enable debugging also if ACTIONS_STEP_DEBUG==true --------- Co-authored-by: rindeal <dev.rindeal@gmail.com> Co-authored-by: William Woodruff <william@trailofbits.com> Upgrade Dependencies: * Update requirements.txt - upgrade sigstore 3.1, upgrade requests 2.32 --------- Signed-off-by: DK96-OS <69859316+DK96-OS@users.noreply.github.com>