8000 Split inputs using `shlex.split` · Issue #77 · sigstore/gh-action-sigstore-python · GitHub
[go: up one dir, main page]
Skip to content

Split inputs using shlex.split #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
woodruffw opened this issue Aug 9, 2023 · 0 comments · Fixed by #104
Closed

Split inputs using shlex.split #77

woodruffw opened this issue Aug 9, 2023 · 0 comments · Fixed by #104
Assignees
@woodruffw
Labels
enhancement New feature or request

Comments

@woodruffw
Copy link
Member

We currently split the inputs passed by the user using str.split, which will be wrong for some inputs (e.g., if the user passes in a filename containing whitespaces). We should instead use shlex.split.
@woodruffw woodruffw added the enhancement New feature or request label Aug 9, 2023
@woodruffw woodruffw self-assigned this Aug 9, 2023
woodruffw added a commit that referenced this issue Jan 10, 2024
@woodruffw
action: use shlex.split
761f0f0 
Closes #77.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw mentioned this issue Jan 10, 2024
Merged
tetsuo-cpp pushed a commit that referenced this issue Jan 11, 2024
@woodruffw
action: use shlex.split (#104)
faa37e3 
* action: use shlex.split

Closes #77.

Signed-off-by: William Woodruff <william@trailofbits.com>

* whitespace selftests

Signed-off-by: William Woodruff <william@trailofbits.com>

* document `inputs` a bit more

Signed-off-by: William Woodruff <william@trailofbits.com>

---------

Signed-off-by: William Woodruff <william@trailofbits.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

action: use shlex.split sigstore/gh-action-sigstore-python
1 participant
@woodruffw
0