Initial commit of GA #998
Initial commit of GA #998
Conversation
* Initial commit of GA This _should_ be feature complete, but definitely initial effort.
|
Starting third-party-check jobs. |
|
Build failed (third-party-check pipeline) integration testing on
Warning: |
|
Nope, there's no need for those variables. We don't have them set in Travis and I think they're only used for recording cassettes. Let me know if this is ready to merge then |
Perhaps I was reading it incorrectly https://github.com/esacteksab/github3.py/runs/1109377212?check_suite_focus=true is one of the failures The other can be seen from here https://github.com/esacteksab/github3.py/actions/runs/252840955 This also shows it in action (no pun intended). |
|
Oh, I don't think the notebooks ever worked, honestly. We probably shouldn't be testing those :/ |
| - name: Run Tox | ||
| run: tox | ||
| env: | ||
| TOXENV: ${{ matrix.PYTHON.TOXENV }} |
There was a problem hiding this comment.
We also want GH_RECORD_MODE here:
There was a problem hiding this comment.
Apologies, but I can't tell what that does. Google and Travis' docs are letting me down. Any idea what this was intended to do so I can find the equivalent capability with Github actions?
There was a problem hiding this comment.
It's used purely by this test suite. It's a custom environment variable that ensures we never talk to the network
There was a problem hiding this comment.
Line 18 in 253b6cd
.github/workflows/build.yml
Outdated
| on: [push] | ||
|
|
||
| jobs: | ||
| build: |
There was a problem hiding this comment.
Can we rename this to test?
.github/workflows/build.yml
Outdated
| @@ -0,0 +1,36 @@ | |||
| name: Python package | |||
There was a problem hiding this comment.
And rename this too? I don't know what to though
There was a problem hiding this comment.
Yeah...same. I pushed something, but mostly in fun. :-/ Naming is hard.
I can use this opportunity to get rid of them if you'd like. |
* Initial commit of GA
|
Starting third-party-check jobs. |
* Initial commit of GA Addresses comments in PR
|
Starting third-party-check jobs. |
|
Build failed (third-party-check pipeline) integration testing on
Warning: |
|
Yeah, let's get rid of the notebooks |
Notebooks is gone.
|
* Initial commit of GA
|
Starting third-party-check jobs. |
|
Build failed (third-party-check pipeline) integration testing on
Warning: |
|
Checked the last run on your repo and it looks good to me. I'm ignoring the py39 error on Travis and merging |
|
Do you want me to put together a PR to remove Travis?
…________________________________
From: Ian Stapleton Cordasco <notifications@github.com>
Sent: Tuesday, September 15, 2020 7:41:30 AM
To: sigmavirus24/github3.py <github3.py@noreply.github.com>
Cc: Barry Morrison <bdmorrison@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [sigmavirus24/github3.py] Initial commit of GA (#998)
Merged #998<#998> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#998 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFILNYFK7FQQR2IT6I7E43SF5OHVANCNFSM4RK425JA>.
|
|
Sure and maybe we can figure out what's going on with https://github.com/sigmavirus24/github3.py/actions/runs/255665322 ? |
|
Ah that's commitlint that we can't address now 🤷 Oh well. Yeah, let's nix Travis |
This comment mentions wanting to migrate to Github Actions and away from Travis. This creates a
build.ymlfile, which I believe is feature complete. I am missingGH_USERNAMEandGH_PASSWORDenv vars that I believe are set in Travis that are required for some of the tests.