Removed py34-flake8 and added py36-flake8. #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmavirus24
reviewed
Apr 9, 2018
.travis.yml
Outdated
| @@ -28,7 +28,7 @@ matrix: | |||
| - python: pypy | |||
| env: TOXENV=pypy | |||
| - env: TOXENV=py27-flake8 | |||
| - env: TOXENV=py34-flake8 | |||
| - env: TOXENV=py36-flake8 | |||
There was a problem hiding this comment.
This may need to look like:
- env: TOXENV=py36-flake8
python: 3.6Based on the Travis failures
There was a problem hiding this comment.
I changed the py27-flake8 as well to explicitly use Python 2.7. I've also moved them under their respective Python versions.
sigmavirus24
reviewed
Apr 9, 2018
.travis.yml
Outdated
| @@ -17,18 +17,20 @@ matrix: | |||
| include: | |||
| - python: 2.7 | |||
| env: TOXENV=py27 | |||
| - python: 2.7 | |||
There was a problem hiding this comment.
Can you share why you re-ordered these? At the moment there's a list of testing followed by style environments. With this change it would be testing with style environments mixed in.
There was a problem hiding this comment.
I thought it was more organised when it's ordered by Python version. But I'll order it like it was before, my bad.
|
Squash and merge and those ugly commits are gone. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #731.