8000 Make plan attribute in authenticated user response optional by electrofelix · Pull Request #813 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content

Make plan attribute in authenticated user response optional #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2018
Merged

Make plan attribute in authenticated user response optional #813

merged 1 commit into from
Mar 31, 2018
+66 −1

Conversation

electrofelix
Copy link
Contributor

Github Enterprise instances <= 2.12.7 do not include the plan
attribute in responses for authenticated user data. Allow this to be
not set and include a note in the documentation that the corresponding
attr may be set to None.

Partially fixes #794

omgjlk
omgjlk previously requested changes Mar 26, 2018
View reviewed changes
Copy link
Collaborator
@omgjlk omgjlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a solid change, and models what was done for other occurrences. There is a formatting issue to be fixed, but once that's done I say this is good to go.

tests/unit/test_users.py
class TestAuthenticatedUserCompatibility_2_12(helper.UnitHelper):

"""Test methods on AuthenticatedUser from Github Enterprise 2.12."""

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flake8 tester is saying there are too many blank lines here. Just take one out and that should appease the CI.

@electrofelix
Make plan attribute in authenticated user response optional
a89d49a 
Github Enterprise instances <= 2.12.7 do not include the `plan`
attribute in responses for authenticated user data. Allow this to be
not set and include a note in the documentation that the corresponding
attr may be set to `None`.

Partially fixes sigmavirus24#794
@electrofelix electrofelix force-pushed the convert-plan-attr-option branch from b9c0ed9 to a89d49a Compare March 30, 2018 12:13
@sigmavirus24 sigmavirus24 dismissed omgjlk’s stale review March 31, 2018 13:39

@electrofelix addressed this review

@sigmavirus24 sigmavirus24 merged commit 8a0d314 into sigmavirus24:develop Mar 31, 2018
@electrofelix electrofelix deleted the convert-plan-attr-option branch April 9, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omgjlk omgjlk omgjlk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@electrofelix @omgjlk @sigmavirus24
0