Require auth for creating gists #802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github3/github.py
Outdated
| def create_gist(self, description, files, public=True): | ||
| """Create a new gist. | ||
|
|
||
| If no login was provided, it will be anonymous. | ||
| Auth is required for creating gists |
There was a problem hiding this comment.
Can we update this to read
.. versionchanged:: 1.1.0
Per `GitHub's recent announcement`_ authentication is now required for creating gists.
.. _GitHub's recent announcement:
<link>
|
Also I realize that I should delete the existing cassette and create a new one given the new API version. |
56e3791 to
80e227f
Compare
|
This is ready for review again @sigmavirus24 |
github3/github.py
Outdated
| If no login was provided, it will be anonymous. | ||
| .. versionchanged:: 1.1.0 | ||
|
|
||
| Per `GitHub's recent announcement`_ authentication is now required for |
There was a problem hiding this comment.
These two lines need to be indented to be part of the versionchanged directive.
Per https://blog.github.com/2018-02-18-deprecation-notice-removing-anonymous-gist-creation/ anonymous gist creation is no longer possible on GitHub. Also updates the betamax cassette to ensure tests still work against current API. Resolves: sigmavirus24#795
80e227f to
2c86e44
Compare
sigmavirus24
approved these changes
Mar 21, 2018
Feel free to merge your own PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per
https://blog.github.com/2018-02-18-deprecation-notice-removing-anonymous-gist-creation/
anonymous gist creation is no longer possible on GitHub.
Resolves: #795
One thought here, the tests pass because there was no specific test for
anonymous gist creation. I'm not sure if we should ADD such a test and ensure
that it fails, but I'll leave that up to the reviewer.