8000 Handle 304 responses from GitHub when users pass etag by sigmavirus24 · Pull Request #799 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content

Handle 304 responses from GitHub when users pass etag #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2018
Merged

Handle 304 responses from GitHub when users pass etag #799

merged 1 commit into from
Mar 20, 2018

Conversation

sigmavirus24
Copy link
Owner

This was an oversight in the behaviour of pre 1.0 _json handling. This
commit makes it explicit and should allow it to continue working.

Refs gh-798

cc @bboe

@sigmavirus24
Handle 304 responses from GitHub when users pass etag
d6c2a1c 
This was an oversight in the behaviour of pre 1.0 _json handling. This
commit makes it explicit and should allow it to continue working.

Refs gh-798
@sigmavirus24 sigmavirus24 requested a review from omgjlk March 20, 2018 00:19
@bboe
Copy link
Contributor
bboe commented Mar 20, 2018

I should probably look at the documentation, but should I not be explicitly passing in the etag?

@sigmavirus24
Copy link
Owner Author

@bboe I want to deprecate that parameter in favour of users moving to cachecontrol.

@sigmavirus24 sigmavirus24 merged commit dcb72b3 into develop Mar 20, 2018
@sigmavirus24 sigmavirus24 deleted the bug/798 branch March 20, 2018 23:47
@bboe
Copy link
Contributor
bboe commented Mar 21, 2018

@sigmavirus24 thanks for the pointer. I didn't know that existed.

@sigmavirus24
Copy link
Owner Author

I've been failing to actually write documentation around this

@sigmavirus24 sigmavirus24 mentioned this pull request Mar 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omgjlk omgjlk omgjlk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sigmavirus24 @bboe @omgjlk
0