Raise exceptions for unexpected status codes #789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also raise exceptions on any 400 or greater status code as discussed in
gh-670
As it stands today, it's hard for people to determine whether None is
returned because that's the API's response or because None is what we
return in the event of a 404 or some other "error"-like status code.
This change undoes that ambiguity and allows people to handle missing or
permission-related problems using exceptions.