Clean up and enhance Release objects #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This started as an effort to break up Release classes for "Short" versions. However I discovered that there is no difference in data when iterating over a Release or an Asset vs a direct GET of them. I still cleaned up the classes to be more in line with other efforts. Remove custom header as Releases are out of prerelease. Update the example data sets with real release data from our own repository. Account for upload url differences from real data. Related: sigmavirus24#670 Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
The Author data comes from the API and fits nicely into the ShortUser object, so make it happen. A test was added to cover it too. Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #670 and it updates the Release object to be more in-line with
other objects we've updated. There is no Short version however, as there is no
difference in data when iterating over such things.