8000 Clean up and enhance Release objects by omgjlk · Pull Request #764 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]

Skip to content

Clean up and enhance Release objects #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2018

Conversation

omgjlk
Copy link
Collaborator
@omgjlk omgjlk commented Jan 4, 2018

This is related to #670 and it updates the Release object to be more in-line with
other objects we've updated. There is no Short version however, as there is no
difference in data when iterating over such things.

omgjlk added 2 commits January 4, 2018 11:58
This started as an effort to break up Release classes for "Short"
versions. However I discovered that there is no difference in data when
iterating over a Release or an Asset vs a direct GET of them. I still
cleaned up the classes to be more in line with other efforts.

Remove custom header as Releases are out of prerelease.

Update the example data sets with real release data from our own
repository.

Account for upload url differences from real data.

Related: sigmavirus24#670

Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
The Author data comes from the API and fits nicely into the ShortUser
object, so make it happen. A test was added to cover it too.

Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
@omgjlk omgjlk closed this Jan 4, 2018
@omgjlk omgjlk reopened this Jan 4, 2018
@sigmavirus24 sigmavirus24 merged commit a15fcf1 into sigmavirus24:develop Jan 6, 2018
@sigmavirus24
Copy link
Owner

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0