8000 Fix a typo in repo/commit.py model confusing author with committer by 01walid · Pull Request #755 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content

Fix a typo in repo/commit.py model confusing author with committer #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2017
Merged

Fix a typo in repo/commit.py model confusing author with committer #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions AUTHORS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,5 @@ Contributors
- Mark Troyer (@discogestalt)

- Becca James (@beccasjames)

- Walid Ziouche (@01walid)
2 changes: 1 addition & 1 deletion github3/repos/commit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def _update_attributes(self, commit):
commit, 'author', users.ShortUser, self
)
self.committer = self._class_attribute(
commit, 'author', users.ShortUser, self
commit, 'committer', users.ShortUser, self
)

#: :class:`Commit <github3.git.Commit>`.
Expand Down
1 change: 1 addition & 0 deletions tests/cassettes/RepoCommit_author_committer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"http_interactions": [{"request": {"body": {"encoding": "utf-8", "string": ""}, "headers": {"User-Agent": "github3.py/1.0.0a4", "Accept-Encoding": "gzip, deflate", "Accept": "application/vnd.github.drax-preview+json", "Connection": "keep-alive", "Accept-Charset": "utf-8", "Content-Type": "application/json"}, "method": "GET", "uri": "https://api.github.com/repos/sigmavirus24/github3.py"}, "response": {"body": {"encoding": "utf-8", "base64_string": "H4sIAAAAAAAAA62YTZPiNhCG/wrlaxgEeGZhXbW1ySnJKXvYXHKhhC2wMrblkmQI45r/nlcfNjap8DHaCwVG/ehVS93uVhvxLEri1WK+WiymUUVLFiXRnuu82caz+hRNo11TFBv/h+L7kh64bNTymYxGiWPFZJS0USH2vAJjOBQUM83yeb6O59OIHqimctPIAuNyrWuVEOIeqnjmsI1iMhWVZpWepaIkDXHWXw9fnoHbSw8x3AgPLmA19xxnDJgiF4pyXRYXGtzU1uRi8E4UhTiCcqn61kSktzSutBRe7T9IgWVLhM4ZnIclvRtHcKUfF2WtWuyg0hueGY7CjkiWPSzM20GWOQDvLZGsFhbYbFUqea25qB4XOLIGTcg9rfgb/RgN1goQI+1xKdYK1uyAs/i4uTNrSS35gaYn4xrJUsYPcPYHkRf2IOpTbeL2TxwK43qu2YZmpYnDHS0Ue59GdnqNQfbBFGF37+kfx3nG+l3FhN9OOhfVpOBbSeVpshNywhGzckdTnNXJEXlkguM6+ZXr35rt5Jdvvx9iCMS4117J1ci1zh8F41iOId3Yk6sIhCcAkPTKTkEcY98SfPp4ShHqdCsk1eJW0rgucARqyfCnOUua0TJIuAUAlAsR5kkLAIgr1bC7jvb1hVuOIl38VE25dSnvnqi5jnYEaKUKeb5iLMiDPaQlXVZGOFRpHobtGC1x3+xu032QVGMPzLYQ2yAOXpTEQlqicureQ3oTqs5QDWMElWwXLNUweqiWgfttZRpIj8RLUGPrg3R2DNJ6jxa02jd0H0btIdh186re07ebRcz12DlTgDQVmuTbJjzJnTlGqasdEO9hLj1jzlBbkFwvc244YFDYWBeUJb9VF1wnesTo2P8ArDmnl2jz+3YZc1uuYbTknJNd0vf0EO/6rN/pHM7h24GgI9ExSPtTTXVuMhemqqlkIaI9grRbimJrNpu1OaO2rC6ZDIxgRwCKyjRH1Riis+0YqHpKqm21vjMyM1TvhaBZkG97CIBuG0O0OsJw/2s0okECLWBILHnBlBZVWI49U4bsSmi+4+k9Hcv1cBuB2q+KVymb0qKY4tRqnnKcY9TaZhdRcLIwDzkCloF7ANepFAxHOsjrkjlGS1ynmbG6EKfgLDTAmCCWDN1NtqEaXclyvlg+zeOnRfx98Tl5WScv8V8Y09TZaMzqCcOWn74v1km89GPqRuUDTDdkOU+eMeSzwSCt+nONb7i4wCcuS/5zaTDoU8xVBAyVys+GP5/Nkv+5VfFmaYEDehFJ9895uHzX3TaF1FyUrEbtMbifcXZxfZrB1RmaukykasaFWRh/w8jF+tM6HlUZqWgq7MfqGTdLR6pREON9PnzYVSd9J2mmpmrjYj9KtGxMq4ontRR/s1Sr4bNzvhkMPPJXfm5yjaUpofonrl/0GparFTI0l1L4y6gKCaJPtLhY8r2yqFnlNXXyF/Ml4o2nrFJYemvaRyzCXs1gDf627A//U9XZP2gLo8TxbcNrvqItd+1nYpUMpoE3zQSd07wPM7ajTaE3rh/AfBkamULUZkamj+hkO3mWN6yi/Irjl/d/AQ1c7THyEwAA", "string": ""}, "headers": {"Server": "GitHub.com", "Date": "Tue, 26 Dec 2017 22:56:57 GMT", "Content-Type": "application/json; charset=utf-8", "Transfer-Encoding": "chunked", "Status": "200 OK", "X-RateLimit-Limit": "60& 8000 quot;, "X-RateLimit-Remaining": "53", "X-RateLimit-Reset": "1514331561", "Cache-Control": "public, max-age=60, s-maxage=60", "Vary": "Accept", "ETag": "W/\"bc5df4451ca741d3339a0b6835b50c39\"", "Last-Modified": "Tue, 26 Dec 2017 18:32:53 GMT", "X-GitHub-Media-Type": "github.v3; param=drax-preview; format=json", "Access-Control-Expose-Headers": "ETag, Link, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval", "Access-Control-Allow-Origin": "*", "Content-Security-Policy": "default-src 'none'", "Strict-Transport-Security": "max-age=31536000; includeSubdomains; preload", "X-Content-Type-Options": "nosniff", "X-Frame-Options": "deny", "X-XSS-Protection": "1; mode=block", "X-Runtime-rack": "0.034249", "Content-Encoding": "gzip", "X-GitHub-Request-Id": "9D58:FD04:238CDFE:4977207:5A42D3B9"}, "status": {"code": 200, "message": "OK"}, "url": "https://api.github.com/repos/sigmavirus24/github3.py"}, "recorded_at": "2017-12-26T22:56:58"}, {"request": {"body": {"encoding": "utf-8", "string": ""}, "headers": {"User-Agent": "github3.py/1.0.0a4", "Accept-Encoding": "gzip, deflate", "Accept": "application/vnd.github.v3.full+json", "Connection": "keep-alive", "Accept-Charset": "utf-8", "Content-Type": "application/json"}, "method": "GET", "uri": "https://api.github.com/repos/sigmavirus24/github3.py/commits/6a0470c992dd97d97fa0fee503153b125141ca4c"}, "response": {"body": {"encoding": "utf-8", "base64_string": "H4sIAAAAAAAAA71Ye1PiyBb/Kl25f6glkveLGncFZUAdRcUZH5cttpN0IJp0sDsB0fK739PhIbo6wjh3o1Uknf6dc3L6vB8l3sdSRbKwYtiK77paELg2/IdYCQkxFV01dU/VTNVQfWz4Ukny0ySJMqnyKOE866dM3FGcEKByQDgn6JDgLKI92EoSHMWwfnM7Wdq50Xga51mUUl6mJIMtAc4EUlNUe0vVtlTnXNMrqlrRlGvpacYsI4tcGlHWzL0F8jRlZBCPd3pR1s+9Mgj4MeEERMU9wfqIsB5BgzyOESN3OeEZ+o/lGihkaYKCiPtpD9ZwnMlhdN/1GXwK6eacsA7t0PYoyvw+8mPMOYLFAI36hKJiF+gAYbHIQJyMEWD2OFW3phFFUSzNCQgOXBw4gYWx6bqBY9mKaerE1lVDNwwA5kxosJ9lA16RZTyIys+fKcN3p1zmUS/Bw4jlXDPkyVu9PBiLW1nw5fLS/EDln2Q4MQ8ur2hRhGZdP80pGJZSkoaERWHkgw5TKrQ2eSaBVMlYTkoSqJeLN9IQx1EAWgIVUJzlTBzolrhq9cb+MTppnKD2fuO4ev79rF6si0Mb8Zpfq1Zru9Xqae30ALfq/Gr3rHZo92+M1lBn+6NqNWju71drB2Cwu35o3Wb91viukTTjeHzQ7tBq2/52qrpR2G7the3Izppxflw/3NNcy+vVd93rPRU3r7NDclI/ZffVxFSGfl05Uo37pEkOqdyhdHxtD7/VN2uudndvt6vfji5uPLp50sqMU7p5p54+BNfRRXPg/1CrlyGrmY2z/tno4fLKC+SGj0mHXh5rJw5jza/HdeuHd7+5e2Hxq+D65jr0mVO9u2fk0ho363fKuTZQT75eX1zVz5Sj8WXCd/PQUpUOrcc5l28a+xq2/LqrttxmtK9fETrw6F5yeZtdHVFFub8KvB9hXhvXSMtXG/63i5jf3OsNfXTRoey+Vjsw9YMs2ecKfWi2d0GQpmNX+Z1+en5nJK3RWaP/cHA1MDzi0rN6VG9dHwzGX+mxlRmj7Q7dbl6EZocWZ1M/3nvzxOB8B3gcpxjOv3AktKw9d+gAMzAt5ISaGtqubRq+YqpWaNqabtue5WACzkZMEqqKpqt4Dggdw1XAIwnAVF0LHd3XbV/xNNd3XNe0dMVXzSCAc5hEQfQi9qEv74W8P5BqqrqlO5ajoC3FUeAcJi4DQQ5NQhv68s+I9hauQ/+N2PX0uZjwC/GgnyVx92UYWoh570W7CaNfiDv8Fa+VYuyqnycLAFgkB6N+zp9x2otEOEuT3k18C68gqFVMTdccG7YNcYbZayGLRa5Ns4HIMn5KM6As8p+cyxP0n8NtkUR6bEpE0JU+yiqCGJfnsvz8OObbwjSO0xEgX0v6MmUtEpfnGBBpcg9Jc2U8YB7lNOsTUBKI/iQ+OOLZKoIU+x8hY/KsGwWCAqR8xkiwgjBTBIgyoiDFY5GdC1K5x30WDYq6ZxWCizigk7IeptFDkRVXoQM4YW5FsbAC+2I/4MhQ2OsKwAngUR6waIj9sVABIz6JhqDOlYm9QgKtbDwQaf77pLDiEZRjOEiE/4Q45uR11TjzrRHxtkKwUKAgvEB1HcswjA/8S3/Xv2b4T3jYgkQ/97GFjSt52Qz36372isJnPG1O6lO+Nqfy+7ztmeRn/W1OaVWPmwNX97k59Pd43YIkLzx2Kb+bFFtcqvx31ugsW3cB+U/0HbMkvAK3nzvcBzXG0nyeSjNFLFtP/h5FrMDtU4pYms/TX0VGhbIHurkshXZaqlhQ2gRBVGQzqWLALIDEZPqkQRQPo5gs2pLlK64DXbLjeKHtaxrWbM1VFHg0Vc1yFdcgfoCJqHcEdDqTqH4/b7bO2mXGxbhByJADUSlJA+gwoaN8IYT2QghoRP0+ptD+SxV448Wp9yoLLlGWCtTSRan8UlqGR6szBNCv8ptWkB/k+p8PHWY0Fj/lT0bC7RUGAgMMQxU4pJ0dtKWaSklHm+LHRLCwC1Uui7w8SxnvULT1qvFa35kUpBvwrni9A3XxFvbAslJo/TfhfwsdYXaLzlk6hpZrfWdxxrMBQ6eZyxpm4BCwK0e1ievZquV5JDQsyw1DlaiWHsCwzNI9YUIL9jadv0znMDCGWdXqwNLmVgdO8W9Y3Vsy//9t7y2uv9UC/8HgU3ZoG05J1cASpzdgiwEJJ6O+yUBwnZM4LKGi4CyhYvi5UQEjnF0VyI84QTxjkz0VtC4mjhG0GRsldN4nxbBwrRgkMhG+ym+DC8rvgou3CCIrgxGnoADTlbkEjMCQjPIKqhQjy8rfoopGX6aaKhfNWVms/fF3CUUh4rnvA5kwj8Fx3qfShjlw9hap+Ys36M310pGKv2dFQSmAtpHQZrnr5VFcdGHra0WVv1ZCa4WYa8LFZ9d0PgSox7VC/2uV2TmsFQqB5+L3aQF0AzPELgyg8ZyZWClOsdyF3idbB7YlJHZsTxnAOcGoGjjPVTrR6FTYiEKCoT7ppqxLYaK8/qzQEpqzA/hcl8vA50p8SUPEN3HtTI2Id8VAYbooTLPQV7dIu1PTTIsedKMiPf319D8WqY3v+xcAAA==", "string": ""}, "headers": {"Server": "GitHub.com", "Date": "Tue, 26 Dec 2017 22:56:58 GMT", "Content-Type": "application/json; charset=utf-8", "Transfer-Encoding": "chunked", "Status": "200 OK", "X-RateLimit-Limit": "60", "X-RateLimit-Remaining": "52", "X-RateLimit-Reset": "1514331561", "Cache-Control": "public, max-age=60, s-maxage=60", "Vary": "Accept", "ETag": "W/\"64ce903ce3d52b94ca3e9b07eb2a72fc\"", "Last-Modified": "Mon, 18 Dec 2017 23:11:20 GMT", "X-GitHub-Media-Type": "github.v3; param=full; format=json", "Access-Control-Expose-Headers": "ETag, Link, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval", "Access-Control-Allow-Origin": "*", "Content-Security-Policy": "default-src 'none'", "Strict-Transport-Security": "max-age=31536000; includeSubdomains; preload", "X-Content-Type-Options": "nosniff", "X-Frame-Options": "deny", "X-XSS-Protection": "1; mode=block", "X-Runtime-rack": "0.043094", "Content-Encoding": "gzip", "X-GitHub-Request-Id": "9D58:FD04:238CE15:497723E:5A42D3B9"}, "status": {"code": 200, "message": "OK"}, "url": "https://api.github.com/repos/sigmavirus24/github3.py/commits/6a0470c992dd97d97fa0fee503153b125141ca4c"}, "recorded_at": "2017-12-26T22:56:58"}], "recorded_with": "betamax/0.8.0"}
10 changes: 10 additions & 0 deletions tests/integration/test_repos_commit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,13 @@ def test_comments(self):

for comment in comments:
assert isinstance(comment, github3.repos.comment.RepoComment)

def test_author_is_not_committer(self):
"""Test we are not confusing author and committer on a commit."""
cassette_name = self.cassette_name('author_committer')
with self.recorder.use_cassette(cassette_name):
repository = self.gh.repository('sigmavirus24', 'github3.py')
commit = repository.commit(
'6a0470c992dd97d97fa0fee503153b125141ca4c'
)
assert commit.author != commit.committer
0