8000 Split-up Gist-related objects as necessary by sigmavirus24 · Pull Request #753 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]

Skip to content

Split-up Gist-related objects as necessary #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2017
Merged

Conversation

sigmavirus24
Copy link
Owner

The Gist and GistFile objects have both short and regular
representations. Further, we needed a separate representation for Gist
forks that are part of the Gist representation.

Refs gh-670

@sigmavirus24 sigmavirus24 requested a review from omgjlk December 26, 2017 18:35
The Gist and GistFile objects have both short and regular
representations. Further, we needed a separate representation for Gist
forks that are part of the Gist representation.

Refs gh-670
@sigmavirus24 sigmavirus24 merged commit b70bd33 into develop Dec 27, 2017
@sigmavirus24 sigmavirus24 deleted the split-up-gist branch December 27, 2017 12:06

#: The name of the file.
self.name = self._get_attribute(gistfile, 'filename')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This attribute name is removed, however it's relied upon in the _repr from the parent class. I think that may cause a traceback when trying to print the object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0