Split-up Gist-related objects as necessary #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Gist and GistFile objects have both short and regular representations. Further, we needed a separate representation for Gist forks that are part of the Gist representation. Refs gh-670
3efa6bf to
ed5f123
Compare
omgjlk
reviewed
Dec 27, 2017
|
|
||
| #: The name of the file. | ||
| self.name = self._get_attribute(gistfile, 'filename') |
There was a problem hiding this comment.
This attribute name is removed, however it's relied upon in the _repr from the parent class. I think that may cause a traceback when trying to print the object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gist and GistFile objects have both short and regular
representations. Further, we needed a separate representation for Gist
forks that are part of the Gist representation.
Refs gh-670