8000 Split up Issue objects by omgjlk · Pull Request #751 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]

Skip to content

Split up Issue objects #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

omgjlk
Copy link
Collaborator
@omgjlk omgjlk commented Dec 20, 2017

This creates 3 classes; one for iterations (Short), one for direct GETs
(Issue), and one for events (EventIssue). Most attributes
are directly assigned, except where otherwise commented.

Some cassettes needed to be updated for the relatively new 'assignees'
attribute that now comes back. A sample json needed to be updated as
well. Cassettes that needed updated that were associated with
authenticated calls got the calls updated to use auto_login as well.

The search tests needed to be updated as well, label name changed and
syntax changed slightly.

Related-to #670

Signed-off-by: Jesse Keating jkeating@j2solutions.net

This creates 3 classes; one for iterations (Short), one for direct GETs
(Issue), and one for events (EventIssue). Most attributes
are directly assigned, except where otherwise commented.

Some cassettes needed to be updated for the relatively new 'assignees'
attribute that now comes back. A sample json needed to be updated as
well. Cassettes that needed updated that were associated with
authenticated calls got the calls updated to use auto_login as well.

Some cassettes will break between older requests and newer, so tag those
tests accordingly. Allow the tests to work in older requests land for
now.

The search tests needed to be updated as well, label name changed and
syntax changed slightly.

Related-to sigmavirus24#670

Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
@omgjlk omgjlk force-pushed the split-issue-object-670 branch from cf102f9 to af8ea28 Compare December 21, 2017 00:27
@omgjlk omgjlk added the ready label Dec 21, 2017
@sigmavirus24 sigmavirus24 merged commit 0657d44 into sigmavirus24:develop Dec 21, 2017
@sigmavirus24
Copy link
Owner

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0