Split up Issue objects #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates 3 classes; one for iterations (Short), one for direct GETs (Issue), and one for events (EventIssue). Most attributes are directly assigned, except where otherwise commented. Some cassettes needed to be updated for the relatively new 'assignees' attribute that now comes back. A sample json needed to be updated as well. Cassettes that needed updated that were associated with authenticated calls got the calls updated to use auto_login as well. Some cassettes will break between older requests and newer, so tag those tests accordingly. Allow the tests to work in older requests land for now. The search tests needed to be updated as well, label name changed and syntax changed slightly. Related-to sigmavirus24#670 Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
cf102f9 to
af8ea28
Compare
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one sugg
2F8C
estion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates 3 classes; one for iterations (Short), one for direct GETs
(Issue), and one for events (EventIssue). Most attributes
are directly assigned, except where otherwise commented.
Some cassettes needed to be updated for the relatively new 'assignees'
attribute that now comes back. A sample json needed to be updated as
well. Cassettes that needed updated that were associated with
authenticated calls got the calls updated to use auto_login as well.
The search tests needed to be updated as well, label name changed and
syntax changed slightly.
Related-to #670
Signed-off-by: Jesse Keating jkeating@j2solutions.net