Implement Organization object refactor #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
120ddb5 to
3a33e62
Compare
| self.login = org['login'] | ||
| self._api = self.url = org['url'] | ||
|
|
||
| def to_org(self): |
| from .repos import Repository | ||
|
|
||
|
|
||
| class Team(GitHubCore): | ||
| class Team(models.GitHubCore): |
github3/orgs.py
Outdated
| #: Various urls (not templates) | ||
| for urltype in ('avatar_url', 'events_url', 'issues_url', | ||
| 'repos_url'): | ||
| self.__setattr__(urltype, org[urltype]) |
There was a problem hiding this comment.
Have I done something to make setattr(self, urltype, org[urltype]) unusable?
There was a problem hiding this comment.
Nope, I just forgot that particular syntax. I have no excuse 😄
|
I have one question about the use of |
3a33e62 to
73a93a8
Compare
|
I fixed up |
Clean them up as done in sigmavirus24#680 for users.py Related-to: sigmavirus24#670 Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
Alter how we import models as well, and fix a missing attribute on a call. Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
This creates 3 new objects, one for iterations (Short), one for direct GETs (Organization), and one for events (EventOrganization). Most attributes can now be directly assigned, aside from a few that are only returned in the API if they are set on the server. Default those to None. Many test cassettes needed to be updated to pick up attributes added to orgs since the cassette was recorded (yay for additive REST APIs...). Introduce a 'auto_login' method to handle either token auth or username/password auth. Use it in the places I needed to update the cassette. Fix a few POST calls that were sending malformed (according to GitHub API) json data. Specifically an empty permission is not accepted. Related-to: sigmavirus24#670 Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
73a93a8 to
181f08d
Compare
|
Rebased this after I merged the Projects API support. Just want to make sure that the CI passes before merging. :) |
|
🎉 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits Org into 3 objects, removes (most) of the None issues.
See commit messages for relevant info per-commit. Each commit should pass tests.
Related to #670